KrustyPlanet/hermes-agent
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(plugins): normalize browser-pasted GitHub repo URLs (#33539)

Browse source 
Accept common GitHub web URLs in `hermes plugins install` by normalizing repository views back to cloneable `.git` URLs, with focused parser coverage.
This commit is contained in:
Teknium 2026-06-13 13:23:59 -07:00 • committed by GitHub
parent 425e777f54
commit 08890d77e6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 75 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

48
tests/hermes_cli/test_plugins_cmd.py
View file

@ -173,6 +173,54 @@ class TestResolveGitUrl:
assert url == "git@github.com:owner/repo.git"
assert subdir == "sub"
@pytest.mark.parametrize(
"identifier",
[
"https://github.com/owner/repo/tree/main",
"https://github.com/owner/repo/blob/main/README.md",
"https://github.com/owner/repo/pull/123",
"https://github.com/owner/repo/commit/abc123def",
"https://github.com/owner/repo/releases/tag/v1.0",
"https://github.com/owner/repo/issues/42",
],
)
def test_github_browser_url_normalized_to_repo(self, identifier):
url, subdir = _resolve_git_url(identifier)
assert url == "https://github.com/owner/repo.git"
assert subdir is None
@pytest.mark.parametrize(
("identifier", "expected_subdir"),
[
("https://github.com/owner/repo/tree/main/plugins/foo", "plugins/foo"),
("https://github.com/owner/repo/tree/feature-branch/plugin", "plugin"),
("https://github.com/owner/repo/tree/main/plugins/foo?plain=1", "plugins/foo"),
("https://github.com/owner/repo.git/tree/main/plugins/foo", "plugins/foo"),
],
)
def test_github_tree_browser_url_preserves_subdir(self, identifier, expected_subdir):
url, subdir = _resolve_git_url(identifier)
assert url == "https://github.com/owner/repo.git"
assert subdir == expected_subdir
@pytest.mark.parametrize(
"identifier",
[
"https://github.com/owner/repo",
"https://github.com/owner/repo.git",
"https://github.com/owner",
"https://github.com/owner/repo/branches",
"https://github.com/owner//tree/main",
"https://gitlab.com/owner/repo/tree/main",
"git@github.com:owner/repo.git",
"file:///tmp/repo/tree/main",
],
)
def test_non_browser_urls_passthrough(self, identifier):
url, subdir = _resolve_git_url(identifier)
assert url == identifier
assert subdir is None
# ── _resolve_subdir_within ──────────────────────────────────────────────────