test(dump): cover terminal backend override reporting
Verifies `hermes debug` surfaces a TERMINAL_ENV override of terminal.backend, reports the config value when no override is present, and emits no spurious note when env and config agree.
This commit is contained in:
parent
b2a4766463
commit
2a08b8c86f
1 changed files with 80 additions and 0 deletions
80
tests/hermes_cli/test_dump_terminal_backend.py
Normal file
80
tests/hermes_cli/test_dump_terminal_backend.py
Normal file
|
|
@ -0,0 +1,80 @@
|
|||
"""`hermes debug` must report the EFFECTIVE terminal backend.
|
||||
|
||||
``terminal.backend`` in config.yaml is bridged to the ``TERMINAL_ENV`` env var,
|
||||
but a ``TERMINAL_ENV`` set in .env / the shell overrides config and is what
|
||||
``terminal_tool`` actually uses. The dump used to print only the config value,
|
||||
which hid the override and made users believe the agent was running ``local``
|
||||
while it was really jailed in a docker/podman sandbox (and vice-versa).
|
||||
"""
|
||||
|
||||
from pathlib import Path
|
||||
from types import SimpleNamespace
|
||||
|
||||
|
||||
def _terminal_line(out: str) -> str:
|
||||
for line in out.splitlines():
|
||||
if line.startswith("terminal:"):
|
||||
return line
|
||||
raise AssertionError(f"no 'terminal:' line in dump output:\n{out}")
|
||||
|
||||
|
||||
def _seed(home: Path, *, config_yaml: str, env_text: str) -> None:
|
||||
home.mkdir(parents=True, exist_ok=True)
|
||||
(home / "config.yaml").write_text(config_yaml)
|
||||
(home / ".env").write_text(env_text)
|
||||
|
||||
|
||||
def test_dump_surfaces_terminal_env_override(monkeypatch, capsys, tmp_path):
|
||||
from hermes_cli import dump
|
||||
from hermes_cli.config import get_hermes_home
|
||||
|
||||
monkeypatch.delenv("TERMINAL_ENV", raising=False)
|
||||
# Keep run_dump's project-.env fallback from touching the real repo.
|
||||
monkeypatch.setattr(dump, "get_project_root", lambda: tmp_path / "noproject")
|
||||
|
||||
home = get_hermes_home()
|
||||
_seed(home, config_yaml="terminal:\n backend: local\n", env_text="TERMINAL_ENV=docker\n")
|
||||
|
||||
dump.run_dump(SimpleNamespace(show_keys=False))
|
||||
|
||||
line = _terminal_line(capsys.readouterr().out)
|
||||
# Effective backend (docker) is what actually runs, not the config 'local'.
|
||||
assert "docker" in line
|
||||
assert "overrides config.yaml" in line
|
||||
# The shadowed config value is still shown so the mismatch is obvious.
|
||||
assert "terminal.backend=local" in line
|
||||
|
||||
|
||||
def test_dump_reports_config_backend_when_no_override(monkeypatch, capsys, tmp_path):
|
||||
from hermes_cli import dump
|
||||
from hermes_cli.config import get_hermes_home
|
||||
|
||||
monkeypatch.delenv("TERMINAL_ENV", raising=False)
|
||||
monkeypatch.setattr(dump, "get_project_root", lambda: tmp_path / "noproject")
|
||||
|
||||
home = get_hermes_home()
|
||||
_seed(home, config_yaml="terminal:\n backend: docker\n", env_text="")
|
||||
|
||||
dump.run_dump(SimpleNamespace(show_keys=False))
|
||||
|
||||
line = _terminal_line(capsys.readouterr().out)
|
||||
assert "docker" in line
|
||||
assert "overrides" not in line
|
||||
|
||||
|
||||
def test_dump_no_override_when_env_matches_config(monkeypatch, capsys, tmp_path):
|
||||
from hermes_cli import dump
|
||||
from hermes_cli.config import get_hermes_home
|
||||
|
||||
monkeypatch.delenv("TERMINAL_ENV", raising=False)
|
||||
monkeypatch.setattr(dump, "get_project_root", lambda: tmp_path / "noproject")
|
||||
|
||||
home = get_hermes_home()
|
||||
# TERMINAL_ENV agrees with config — no spurious "override" note.
|
||||
_seed(home, config_yaml="terminal:\n backend: docker\n", env_text="TERMINAL_ENV=docker\n")
|
||||
|
||||
dump.run_dump(SimpleNamespace(show_keys=False))
|
||||
|
||||
line = _terminal_line(capsys.readouterr().out)
|
||||
assert "docker" in line
|
||||
assert "overrides" not in line
|
||||
Loading…
Add table
Add a link
Reference in a new issue