KrustyPlanet/hermes-agent
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

chore(approval): tighten allow_permanent comments + DRY the no-always opt set

Browse source 
Collapse the verbose multi-line rationale comments across the TUI/desktop/
backend approval surfaces into single-line "why" notes, and derive
APPROVAL_OPTS_NO_ALWAYS from APPROVAL_OPTS instead of re-listing it.
No behavior change.
This commit is contained in:
Brooklyn Nicholson 2026-06-11 18:42:59 -05:00
parent 81436e143e
commit 55a18e6860
7 changed files with 10 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tools/approval.py
View file

@ -1428,12 +1428,8 @@ def check_all_command_guards(command: str, env_type: str,
"pattern_key": primary_key,
"pattern_keys": all_keys,
"description": combined_desc,
# Mirror the CLI's allow_permanent gate (see prompt_dangerous_approval
# below). When a tirith content-security warning is present the
# backend silently downgrades an "always" choice to session scope
# (see the persistence loop after the decision), so the UI must not
# offer a permanent allow it can't honor. Without this field the
# TUI/desktop always render "Always allow".
# Mirror the CLI's allow_permanent gate: a tirith warning downgrades
# "always" to session scope below, so the UI must not offer it.
"allow_permanent": not has_tirith,
}
decision = _await_gateway_decision(