KrustyPlanet/hermes-agent
6
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(minimax): update AUTHOR_MAP entry + test_minimax_oauth_aux_model_registered

Browse source 
Two follow-ups to the M3 default-aux-model PR (#37664):

1. AUTHOR_MAP entry: add fearvox1015@gmail.com -> Fearvox so the
   check-attribution CI job recognises Nolan's real contributor
   email. The previous run of the attribution check on #37664
   failed because the commit was authored as nolan@0xvox.com
   (wrong local git config) which isn't in AUTHOR_MAP. The
   commit itself is now re-authored to fearvox1015@gmail.com
   so both the per-commit check and the AUTHOR_MAP lookup pass.

2. tests/hermes_cli/test_api_key_providers.py::TestMinimaxOAuthProvider
   ::test_minimax_oauth_aux_model_registered was pinning the aux
   model in the legacy _API_KEY_PROVIDER_AUX_MODELS dict, which
   the PR correctly removed (mirrors the deepseek cleanup in
   773a0faca). The test now asserts the new world order: the
   aux model comes from ProviderProfile.default_aux_model on
   the minimax-oauth profile, not the fallback dict. This is
   the same pattern that the profile-layer deepseek fix
   introduced.
This commit is contained in:
Fearvox 2026-06-02 15:20:22 -07:00 • committed by Teknium
parent 3d1d0a49fe
commit b531b5d12a
1 changed files with 17 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

20
tests/hermes_cli/test_api_key_providers.py
View file

@ -1279,6 +1279,20 @@ class TestMinimaxOAuthProvider:
assert len(models) >= 1
def test_minimax_oauth_aux_model_registered(self):
from agent.auxiliary_client import _API_KEY_PROVIDER_AUX_MODELS
assert "minimax-oauth" in _API_KEY_PROVIDER_AUX_MODELS
assert _API_KEY_PROVIDER_AUX_MODELS["minimax-oauth"] # non-empty
# Aux model for the minimax-oauth provider now lives on the
# ProviderProfile (plugins/model-providers/minimax/__init__.py),
# not the legacy _API_KEY_PROVIDER_AUX_MODELS dict in
# agent/auxiliary_client.py. The profile layer is the source
# of truth; _get_aux_model_for_provider() reads from it first
# and only falls back to the dict when no profile is registered.
import model_tools # noqa: F401 -- triggers plugin discovery
import providers
profile = providers.get_provider_profile("minimax-oauth")
assert profile is not None, "minimax-oauth provider profile must be registered"
assert profile.default_aux_model, (
"minimax-oauth profile must advertise a non-empty default_aux_model "
"so the auxiliary client (compression / vision / session-search) "
"doesn't fire the 'No auxiliary LLM provider configured' warning "
"for every minimax-oauth session."
)