Full codebase pass using the /clean doctrine (KISS/DRY, no one-off
helpers, no variables-used-once, pure functional where natural,
inlined obvious one-liners, killed dead exports, narrowed types,
spaced JSX). All contracts preserved — no RPC method, event name,
or exported type shape changed.
app/ — 15 files, -134 LOC
- inlined 4 one-off helpers (titleCase, isLong, statusToneFrom,
focusOutside predicate)
- stores to arrow-const style (buildUiState, buildTurnState,
buildOverlayState plus get/patch/reset triplets)
- functional slash/registry byName map (flatMap over for-loops)
- dropped dead param `live` in cancelOverlayFromCtrlC
- DRY'd duplicate shift() call in scrollWithSelection
- consolidated sections.push calls in /help
components/ — 12 files, -40 LOC
- extracted inline prop types to interfaces at file bottom (13×)
- inlined 6 one-off vars (pctLabel, logoW, heroW, cwd, title, hint)
- promoted HEART_COLORS + OPTS/LABELS to module scope
- JSX sibling spacing across 9 files
- un-shadowed `raw` in textInput
- components/thinking.tsx + components/markdown.tsx untouched
(structurally load-bearing / edge-case-heavy)
config content domain protocol/ — 8 files, -77 LOC
- tightened 3 regexes (MOUSE_TRACKING, looksLikeSlashCommand,
hasInterpolation — dropped stateful lastIndex dance)
- dead export ParsedSlashCommand removed
- MODES narrowed to `as const`, `.find(m => m === s)` replaces
`.includes() ? (as cast) : null`
- fortunes.ts hash via reduce
- fmtDuration ternary chain
- inlined aboveViewport predicate in viewport.ts
hooks/ + lib/ — 9 files, -38 LOC
- ANSI_RE via String.fromCharCode(27) + WS_RE lifted to module
scope (no more eslint-disable no-control-regex)
- compactPreview/edgePreview/thinkingPreview → ternary arrows
- useCompletion: hoisted pathReplace, moved stale-ref guard earlier
- useInputHistory: dropped useCallback wrapper (append is stable)
- useVirtualHistory: replaced 4× any with unknown + narrow
MeasuredNode interface + one cast site
root TS — 3 files, -63 LOC
- banner.ts: parseRichMarkup via matchAll instead of exec/lastIndex,
artWidth via reduce
- gatewayClient.ts: resolvePython candidate list collapse, inlined
one-branch guards in dispatch/pushLog/drain/request
- types.ts: alpha-sorted ActiveTool / Msg / SudoReq / SecretReq
members
eslint config
- disabled react-hooks/exhaustive-deps on packages/hermes-ink/**
(compiled by react/compiler, deps live in $[N] memo arrays that
eslint can't introspect) and removed the now-orphan in-file
disable directive in ScrollBox.tsx
fixes (not from the cleaner pass)
- useComposerState: unlinkSync(file) + try/catch → rmSync(file,
{ force: true }) — kills the no-empty lint error and is more
idiomatic
- useConfigSync: added setBellOnComplete + setVoiceEnabled to the
two useEffect dep arrays (they're stable React setState setters;
adding is safe and silences exhaustive-deps)
verification
- npx eslint src/ packages/ → 0 errors, 0 warnings
- npm run type-check → clean
- npm test → 50/50
- npm run build → 394.8kb ink-bundle.js, 11ms esbuild
- pytest tests/tui_gateway/ tests/test_tui_gateway_server.py
tests/hermes_cli/test_tui_resume_flow.py
tests/hermes_cli/test_tui_npm_install.py → 57/57
116 lines
3.3 KiB
TypeScript
116 lines
3.3 KiB
TypeScript
import { parseSlashCommand } from '../domain/slash.js'
|
|
import type { SlashExecResponse } from '../gatewayTypes.js'
|
|
import { asCommandDispatch, rpcErrorMessage } from '../lib/rpc.js'
|
|
|
|
import type { SlashHandlerContext } from './interfaces.js'
|
|
import { findSlashCommand } from './slash/registry.js'
|
|
import type { SlashRunCtx } from './slash/types.js'
|
|
import { getUiState } from './uiStore.js'
|
|
|
|
export function createSlashHandler(ctx: SlashHandlerContext): (cmd: string) => boolean {
|
|
const { gw } = ctx.gateway
|
|
const { catalog } = ctx.local
|
|
const { page, send, sys } = ctx.transcript
|
|
|
|
const handler = (cmd: string): boolean => {
|
|
const flight = ++ctx.slashFlightRef.current
|
|
const ui = getUiState()
|
|
const sid = ui.sid
|
|
const parsed = parseSlashCommand(cmd)
|
|
const argTail = parsed.arg ? ` ${parsed.arg}` : ''
|
|
|
|
const stale = () => flight !== ctx.slashFlightRef.current || getUiState().sid !== sid
|
|
|
|
const guarded =
|
|
<T>(fn: (r: T) => void) =>
|
|
(r: null | T): void => {
|
|
if (!stale() && r) {
|
|
fn(r)
|
|
}
|
|
}
|
|
|
|
const guardedErr = (e: unknown) => {
|
|
if (!stale()) {
|
|
sys(`error: ${rpcErrorMessage(e)}`)
|
|
}
|
|
}
|
|
|
|
const runCtx: SlashRunCtx = { ...ctx, flight, guarded, guardedErr, sid, stale, ui }
|
|
|
|
const found = findSlashCommand(parsed.name)
|
|
|
|
if (found) {
|
|
found.run(parsed.arg, runCtx, cmd)
|
|
|
|
return true
|
|
}
|
|
|
|
if (catalog?.canon) {
|
|
const needle = `/${parsed.name}`.toLowerCase()
|
|
|
|
const matches = [
|
|
...new Set(
|
|
Object.entries(catalog.canon)
|
|
.filter(([alias]) => alias.startsWith(needle))
|
|
.map(([, canon]) => canon)
|
|
)
|
|
]
|
|
|
|
if (matches.length === 1 && matches[0]!.toLowerCase() !== needle) {
|
|
return handler(`${matches[0]}${argTail}`)
|
|
}
|
|
|
|
if (matches.length > 1) {
|
|
sys(`ambiguous command: ${matches.slice(0, 6).join(', ')}${matches.length > 6 ? ', …' : ''}`)
|
|
|
|
return true
|
|
}
|
|
}
|
|
|
|
gw.request<SlashExecResponse>('slash.exec', { command: cmd.slice(1), session_id: sid })
|
|
.then(r => {
|
|
if (stale()) {
|
|
return
|
|
}
|
|
|
|
const body = r?.output || `/${parsed.name}: no output`
|
|
const text = r?.warning ? `warning: ${r.warning}\n${body}` : body
|
|
const long = text.length > 180 || text.split('\n').filter(Boolean).length > 2
|
|
|
|
long ? page(text, parsed.name[0]!.toUpperCase() + parsed.name.slice(1)) : sys(text)
|
|
})
|
|
.catch(() => {
|
|
gw.request('command.dispatch', { arg: parsed.arg, name: parsed.name, session_id: sid })
|
|
.then((raw: unknown) => {
|
|
if (stale()) {
|
|
return
|
|
}
|
|
|
|
const d = asCommandDispatch(raw)
|
|
|
|
if (!d) {
|
|
return sys('error: invalid response: command.dispatch')
|
|
}
|
|
|
|
if (d.type === 'exec' || d.type === 'plugin') {
|
|
return sys(d.output || '(no output)')
|
|
}
|
|
|
|
if (d.type === 'alias') {
|
|
return handler(`/${d.target}${argTail}`)
|
|
}
|
|
|
|
if (d.type === 'skill') {
|
|
sys(`⚡ loading skill: ${d.name}`)
|
|
|
|
return d.message?.trim() ? send(d.message) : sys(`/${parsed.name}: skill payload missing message`)
|
|
}
|
|
})
|
|
.catch(guardedErr)
|
|
})
|
|
|
|
return true
|
|
}
|
|
|
|
return handler
|
|
}
|