d431dfc448
A /learn request can mix the source(s) to gather (paths, URLs, "what we just did") with requirements that shape the skill (focus, scope, what to omit). When a request led with a path or link, the agent fetched it and treated the trailing prose as incidental, dropping the user's stated focus — the symptom @GrenFX reported. The input layer was never the cause: both CLI (split(None, 1)) and gateway (get_command_args()) capture the full free-text argument. The gap was in build_learn_prompt, which dumped the request as one undifferentiated source blob. build_learn_prompt now tells the agent the request may mix sources and requirements in any order, that prose after a path/link is authoring guidance to honor (not noise), and to never fetch the first source and ignore the rest. Adds step 1b: apply every requirement to what the SKILL.md covers, not just which sources get read. Both surfaces inherit it; no parser change, zero tool footprint.
107 lines
4.8 KiB
Python
107 lines
4.8 KiB
Python
"""Tests for /learn — open-ended skill distillation.
|
|
|
|
Covers the shared prompt builder (agent.learn_prompt.build_learn_prompt) and
|
|
the slash-command registry wiring. /learn has no engine and no model tool: it
|
|
builds a standards-guided prompt that the live agent runs as a normal turn, so
|
|
these are the load-bearing behavior contracts.
|
|
"""
|
|
|
|
from agent.learn_prompt import build_learn_prompt, _AUTHORING_STANDARDS
|
|
|
|
|
|
class TestBuildLearnPrompt:
|
|
def test_embeds_the_user_request_verbatim(self):
|
|
req = "the REST client in ~/projects/acme-sdk, focus on auth"
|
|
prompt = build_learn_prompt(req)
|
|
assert req in prompt
|
|
|
|
def test_always_includes_the_authoring_standards(self):
|
|
# The standards are what make distilled skills match house style;
|
|
# they must travel with every prompt regardless of input.
|
|
for req in ["", "a url https://x/y", "what we just did"]:
|
|
assert _AUTHORING_STANDARDS in build_learn_prompt(req)
|
|
|
|
def test_instructs_saving_via_skill_manage_not_a_raw_file(self):
|
|
prompt = build_learn_prompt("learn the thing")
|
|
assert "skill_manage" in prompt
|
|
|
|
def test_references_gather_tools_for_open_ended_sourcing(self):
|
|
# Open-ended sourcing relies on the agent's own tools, named so it
|
|
# knows dirs/URLs/conversation/paste all route through existing tools.
|
|
prompt = build_learn_prompt("learn from somewhere")
|
|
for tool in ("read_file", "search_files", "web_extract"):
|
|
assert tool in prompt
|
|
|
|
def test_separates_sources_from_requirements(self):
|
|
# The reported bug (@GrenFX, Jun 2026): when a request leads with a
|
|
# path/URL, the agent fetched it and ignored the trailing prose. The
|
|
# prompt must tell the agent the request can MIX sources and
|
|
# requirements, and that prose after a source is authoring guidance to
|
|
# honor — not noise to drop.
|
|
prompt = build_learn_prompt(
|
|
"https://api.example.com/docs focus on the auth flow, skip deprecated bits"
|
|
)
|
|
low = prompt.lower()
|
|
# Carries the whole request verbatim (no truncation at the URL).
|
|
assert "focus on the auth flow, skip deprecated bits" in prompt
|
|
# Explicitly distinguishes sources from requirements.
|
|
assert "requirement" in low
|
|
# Names the failure mode it's guarding against.
|
|
assert "never fetch the first source" in low
|
|
|
|
def test_empty_request_falls_back_to_the_conversation(self):
|
|
# Bare /learn should distill "what we just did", not error.
|
|
prompt = build_learn_prompt("")
|
|
assert "conversation" in prompt.lower()
|
|
# And still carries the standards + save instruction.
|
|
assert "skill_manage" in prompt
|
|
|
|
def test_whitespace_only_request_is_treated_as_empty(self):
|
|
assert build_learn_prompt(" \n ") == build_learn_prompt("")
|
|
|
|
def test_description_length_rule_is_in_the_standards(self):
|
|
# The single most-violated rule must be explicit in the prompt.
|
|
assert "60" in _AUTHORING_STANDARDS
|
|
|
|
def test_teaches_the_full_hardline_standards(self):
|
|
# description length — otherwise distilled skills miss platform gating,
|
|
# author credit, and the tool-framing table. Lock the coverage in.
|
|
std = _AUTHORING_STANDARDS.lower()
|
|
# #1 description: the count-and-trim self-check (the reported bug).
|
|
assert "count" in std and "60" in std
|
|
# #3 platforms gating against OS-bound primitives.
|
|
assert "platforms" in std
|
|
# author is always the literal Hermes, never the host/OS identity (#52368).
|
|
assert "author: always the literal value `hermes`" in std
|
|
assert "never fill it from the host" in std
|
|
# #2 Hermes-tool framing names the wrapped tools, not shell utilities.
|
|
for tool in ("read_file", "search_files", "patch", "write_file"):
|
|
assert tool in std
|
|
# #6 scripts/references/templates layout.
|
|
assert "scripts/" in _AUTHORING_STANDARDS
|
|
|
|
|
|
class TestLearnRegistryWiring:
|
|
def test_learn_is_registered_and_resolves(self):
|
|
from hermes_cli.commands import resolve_command
|
|
|
|
cmd = resolve_command("learn")
|
|
assert cmd is not None
|
|
assert cmd.name == "learn"
|
|
|
|
def test_learn_is_in_tools_and_skills_category(self):
|
|
from hermes_cli.commands import resolve_command
|
|
|
|
assert resolve_command("learn").category == "Tools & Skills"
|
|
|
|
def test_learn_works_on_the_gateway(self):
|
|
# /learn must reach the gateway runner (it's a both-surfaces command),
|
|
# not be CLI-only.
|
|
from hermes_cli.commands import GATEWAY_KNOWN_COMMANDS
|
|
|
|
assert "learn" in GATEWAY_KNOWN_COMMANDS
|
|
|
|
def test_learn_is_not_cli_only(self):
|
|
from hermes_cli.commands import resolve_command
|
|
|
|
assert not resolve_command("learn").cli_only
|