f0678b031e
_normalize_preset uses bare float() and int() to coerce reference_temperature, aggregator_temperature, and max_tokens from config.yaml. When a user hand-edits a non-numeric value (e.g. max_tokens: "8k" or reference_temperature: "hot"), the coercion raises ValueError. Since normalize_moa_config runs on every model-selection and MoA turn (via resolve_moa_preset), the crash is unrecoverable and blocks all MoA usage until the config is manually fixed. Replace the bare casts with _coerce_float / _coerce_int helpers that fall back to the default on TypeError/ValueError instead of raising.
136 lines
4.7 KiB
Python
136 lines
4.7 KiB
Python
from hermes_cli.moa_config import (
|
|
DEFAULT_MOA_AGGREGATOR,
|
|
DEFAULT_MOA_PRESET_NAME,
|
|
DEFAULT_MOA_REFERENCE_MODELS,
|
|
build_moa_turn_prompt,
|
|
decode_moa_turn,
|
|
exact_moa_preset_name,
|
|
normalize_moa_config,
|
|
resolve_moa_preset,
|
|
set_active_moa_preset,
|
|
)
|
|
|
|
|
|
def test_normalize_moa_config_uses_default_named_preset():
|
|
cfg = normalize_moa_config({})
|
|
|
|
assert cfg["default_preset"] == DEFAULT_MOA_PRESET_NAME
|
|
assert list(cfg["presets"]) == [DEFAULT_MOA_PRESET_NAME]
|
|
assert cfg["reference_models"] == DEFAULT_MOA_REFERENCE_MODELS
|
|
assert cfg["aggregator"] == DEFAULT_MOA_AGGREGATOR
|
|
|
|
|
|
def test_normalize_moa_config_preserves_named_presets():
|
|
cfg = normalize_moa_config(
|
|
{
|
|
"default_preset": "coding",
|
|
"presets": {
|
|
"coding": {
|
|
"reference_models": [{"provider": "openai-codex", "model": "gpt-5.5"}],
|
|
"aggregator": {"provider": "openrouter", "model": "anthropic/claude-opus-4.8"},
|
|
},
|
|
"review": {
|
|
"reference_models": [{"provider": "openrouter", "model": "deepseek/deepseek-v4-pro"}],
|
|
"aggregator": {"provider": "openrouter", "model": "anthropic/claude-opus-4.8"},
|
|
},
|
|
},
|
|
}
|
|
)
|
|
|
|
assert cfg["default_preset"] == "coding"
|
|
assert set(cfg["presets"]) == {"coding", "review"}
|
|
assert cfg["reference_models"] == [{"provider": "openai-codex", "model": "gpt-5.5"}]
|
|
|
|
|
|
def test_legacy_flat_config_becomes_default_preset():
|
|
cfg = normalize_moa_config(
|
|
{
|
|
"reference_models": [{"provider": "openai-codex", "model": "gpt-5.5"}],
|
|
"aggregator": {"provider": "openrouter", "model": "anthropic/claude-opus-4.8"},
|
|
}
|
|
)
|
|
|
|
assert cfg["presets"][DEFAULT_MOA_PRESET_NAME]["reference_models"] == [
|
|
{"provider": "openai-codex", "model": "gpt-5.5"}
|
|
]
|
|
|
|
|
|
def test_normalize_moa_config_tolerates_non_numeric_values():
|
|
"""Non-numeric strings in hand-edited config.yaml must degrade to defaults
|
|
instead of crashing normalize_moa_config with ValueError."""
|
|
cfg = normalize_moa_config(
|
|
{
|
|
"presets": {
|
|
"broken": {
|
|
"max_tokens": "notanumber",
|
|
"reference_temperature": "hot",
|
|
"aggregator_temperature": "",
|
|
}
|
|
}
|
|
}
|
|
)
|
|
|
|
preset = cfg["presets"]["broken"]
|
|
assert preset["max_tokens"] == 4096
|
|
assert preset["reference_temperature"] == 0.6
|
|
assert preset["aggregator_temperature"] == 0.4
|
|
|
|
|
|
def test_normalize_moa_config_coerces_numeric_strings():
|
|
"""Valid numeric strings (e.g. from YAML round-trip) must coerce correctly."""
|
|
cfg = normalize_moa_config({"max_tokens": "8192", "reference_temperature": "0.9"})
|
|
|
|
preset = cfg["presets"][DEFAULT_MOA_PRESET_NAME]
|
|
assert preset["max_tokens"] == 8192
|
|
assert preset["reference_temperature"] == 0.9
|
|
|
|
|
|
def test_normalize_moa_config_coerces_float_max_tokens():
|
|
"""max_tokens: 4096.0 (float from YAML) must coerce to int."""
|
|
cfg = normalize_moa_config({"max_tokens": 4096.0})
|
|
assert cfg["presets"][DEFAULT_MOA_PRESET_NAME]["max_tokens"] == 4096
|
|
|
|
cfg2 = normalize_moa_config({"max_tokens": "4096.5"})
|
|
assert cfg2["presets"][DEFAULT_MOA_PRESET_NAME]["max_tokens"] == 4096
|
|
|
|
|
|
def test_exact_preset_matching_is_not_fuzzy():
|
|
config = {"presets": {"coding": {}, "review": {}}}
|
|
|
|
assert exact_moa_preset_name(config, "coding") == "coding"
|
|
assert exact_moa_preset_name(config, "cod") is None
|
|
assert exact_moa_preset_name(config, "coding please fix this") is None
|
|
|
|
|
|
def test_active_preset_toggle_validation():
|
|
config = {"default_preset": "coding", "presets": {"coding": {}, "review": {}}}
|
|
|
|
active = set_active_moa_preset(config, "review")
|
|
assert active["active_preset"] == "review"
|
|
|
|
inactive = set_active_moa_preset(active, "")
|
|
assert inactive["active_preset"] == ""
|
|
|
|
|
|
def test_resolve_moa_preset_returns_requested_model_set():
|
|
cfg = normalize_moa_config(
|
|
{
|
|
"presets": {
|
|
"coding": {"reference_models": [{"provider": "openai-codex", "model": "gpt-5.5"}]},
|
|
"review": {"reference_models": [{"provider": "openrouter", "model": "deepseek/deepseek-v4-pro"}]},
|
|
}
|
|
}
|
|
)
|
|
|
|
assert resolve_moa_preset(cfg, "review")["reference_models"] == [
|
|
{"provider": "openrouter", "model": "deepseek/deepseek-v4-pro"}
|
|
]
|
|
|
|
|
|
def test_build_moa_turn_prompt_encodes_one_shot_default_preset():
|
|
prompt = build_moa_turn_prompt("write a file then inspect it")
|
|
|
|
decoded_prompt, cfg = decode_moa_turn(prompt)
|
|
assert decoded_prompt == "write a file then inspect it"
|
|
assert cfg is not None
|
|
assert cfg["reference_models"] == DEFAULT_MOA_REFERENCE_MODELS
|