tdd-cleanup-extraction #1

Merged

jez merged 10 commits from tdd-cleanup-extraction into master

2026-07-01 20:35:48 +00:00

jez commented

2026-07-01 20:35:34 +00:00

Owner

No description provided.

jez added 10 commits

2026-07-01 20:35:34 +00:00

Phase 0-1a: scaffold project + test all 16 transforms fd2484c315

- pyproject.toml with pytest config
- tests/ directory with conftest.py (seeded RNG fixture, sys.path setup)
- test_transforms.py: 134 tests covering all 16 transforms
  - Determinism (same seed + same input = same output)
  - Cross-instance seed determinism
  - Output shape for 5 test points per transform
  - Singularity handling (ZeroDivisionError at origin)
  - Specific behavior tests (Moebius/InverseJulia complex, Spherical div-by-zero)
  - get_name() returns class name
  - Bubble, Sinusoidal, Swirl, Ex output range checks

Phase 1b: test baseforms.py — Transform, ComplexTransform, MoebiusBase, SphericalBase 37cd8931d1

21 tests covering:
- Transform base: get_name, colour averaging (half-black, half-white)
- ComplexTransform: f(z) bridge to transform(px, py)
- MoebiusBase: naming (MoebX), composition, determinism, colour delegation
- SphericalBase: naming (SpheriX), composition, double-spherical, determinism

Phase 2: extract box_filter_colour as pure function edb477ece6

- Extract box_filter_colour(current_rgb, transform_rgb) → (r,g,b)
  from Transform.transform_colour. Pure function, no state, no RNG.
- 8 tests: black+white, identical, black+black, channel independence,
  determinism, output range (100 random values), commutativity, identity
- Transform.transform_colour now delegates to box_filter_colour
  preserving full backward compatibility

Phase 3: refactor IFS — from_config factory + test core methods dacab1b9cd

- Add IFS.from_config(rng, transform_instances) static factory that
  bypasses the reflection-based transform discovery in __init__
- 16 tests covering:
  - from_config: creation, weights, total_weight, empty list
  - choose_transform: returns from list, proportional weights,
    single transform, empty list returns None
  - final_transform: zero identity, scale-by-half, deterministic, shape
  - add_transform: appends, positive weight, multiple, seed-deterministic

Phase 4: extract Ward tone mapping + seed heuristics from image.py 35588c2492

Extracted pure functions with type annotations:
- ward_scalefactor(data, width, height, iterations) — Ward's 1994 formula
- gamma_encode_pixel(value, scalefactor, iterations) — gamma correction
- black_ratio(data) — sparse detail metric (total/black_count)
- colour_ratio(data) — gradient smoothness metric (unique/total)
- interest_factor(data) — combined visual appeal heuristic

Image class methods now delegate to module-level functions.
26 tests covering scalefactor properties, gamma encoding, black/colour ratios,
interest factor behaviors, and determinism.

Phase 5: test safelog10 edge cases df39dbd536

8 tests covering: positive values, zero (caught ValueError → 0.0),
negative inputs (→ 0.0), very small positive, sub-unit values,
large values, integer inputs, near-machine-epsilon values.

Phase 6a: new argparse CLI + bugfix tostring→tobytes c5de515e63

- New cli.py module replacing pyifs.py's getopt + PySimpleGUI entry point
- argparse-based: --seed, -w/--width, -H/--height, --iterations, --num-points,
  --num-transforms, --moebius-chance, --spherical-chance, -o/--output,
  -n/--count, --exclude, --include, --verbose, --version
- parse_transform_filter() helper for comma-separated include/exclude lists
- headless batch mode with seed auto-generation
- 23 tests: argument parsing, defaults, short/long forms, combined options,
  main() end-to-end with file output verification
- Also fixed image.py: tostring() → tobytes() (removed in Python 3.12+)

Phase 6b: replace hand-rolled PNG writer with Pillow 84a7664a9d

- Add save_pillow() method using PIL.Image for PNG output
- Refactor save() to delegate to save_pillow() (backward compatible)
- Remove output_chunk() and unused struct/zlib imports
- 5 tests: valid PNG creation, deterministic output, black image,
  non-square images, legacy save() compatibility
- All 241 tests pass

Phase 6c: pyifs.py thin wrapper + cleanup 6f7364e5b1

- pyifs.py now delegates to cli.main() (backward compatible entry point)
- All 241 tests pass

gitignore: modernize from 2019-vintage 5-line file c41a8aafab

- Added __pycache__/, *.pyo for Python 3 compatibility
- Added .pytest_cache/ and test_output/ for new test infrastructure
- Added .DS_Store, Thumbs.db for cross-platform hygiene
- Added coverage files (.coverage, htmlcov/)
- Added package build artifacts (egg-info, dist, build)
- Added virtual environment directories (.venv, venv, env)
- Preserved existing entries (best/, im/, data/, test.png) as-is

jez merged commit 025df0ef52 into master

2026-07-01 20:35:48 +00:00

jez referenced this pull request from a commit

2026-07-01 20:35:48 +00:00

Merge pull request 'tdd-cleanup-extraction' (#1) from tdd-cleanup-extraction into master

jez deleted branch tdd-cleanup-extraction

2026-07-01 20:35:50 +00:00