refactor: remove transform_llm_output hook registration #2

Merged

BarnacleBoy merged 1 commit from refactor/remove-hook-registration into main

2026-09-10 14:47:45 +00:00

BarnacleBoy commented

2026-09-10 14:47:09 +00:00

Owner

Removes the transform_llm_output hook registration from em-dash-sub.

The new barnacleboy-output wrapper plugin now owns the hook. It imports transform_em_dashes from this module and transform_vocabulary from spongebob-vocab, applying them in sequence. This solves two problems:

Mutual exclusion: Two plugins were fighting over a single transform_llm_output slot. Only the first registered callback's result was used. Now the wrapper composes both transforms.
Wrong order: If SpongeBob vocab ran first (hypothetically), it would add words like "Tartar sauce!" that then got split by em dash replacement. Now em dashes are always cleaned first, then vocab applies on clean text.

The register() function is kept as a no-op for backward compatibility.

Removes the `transform_llm_output` hook registration from em-dash-sub. The new `barnacleboy-output` wrapper plugin now owns the hook. It imports `transform_em_dashes` from this module and `transform_vocabulary` from `spongebob-vocab`, applying them in sequence. This solves two problems: 1. **Mutual exclusion**: Two plugins were fighting over a single `transform_llm_output` slot. Only the first registered callback's result was used. Now the wrapper composes both transforms. 2. **Wrong order**: If SpongeBob vocab ran first (hypothetically), it would add words like "Tartar sauce!" that then got split by em dash replacement. Now em dashes are always cleaned first, then vocab applies on clean text. The `register()` function is kept as a no-op for backward compatibility.

BarnacleBoy added 1 commit

2026-09-10 14:47:09 +00:00

refactor: remove transform_llm_output hook registration 8f7f4da38e

Hook registration moved to barnacleboy-output wrapper plugin.
The barnacleboy-output plugin now owns the transform_llm_output hook
and imports this module's transform_em_dashes function directly.

This allows multiple output transforms (em dash sub + SpongeBob vocab)
to compose sequentially instead of competing for the single hook slot.

BarnacleBoy merged commit 3de4ca0f47 into main

2026-09-10 14:47:45 +00:00

BarnacleBoy deleted branch refactor/remove-hook-registration

2026-09-10 14:47:45 +00:00

BarnacleBoy referenced this pull request from a commit

2026-09-10 14:47:46 +00:00

Merge pull request 'refactor: remove transform_llm_output hook registration' (#2) from refactor/remove-hook-registration into main